Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: swap release process to release-please #508

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

voxpelli
Copy link
Member

What is the purpose of this pull request?

To improve the release process by swapping to release-please. Fixes #506

What changes did you make? (Give an overview)

Removed cycjimmy/semantic-release-action and added googleapis/release-please-action

@ota-meshi
Copy link
Member

Do you think we also need to replace the version in package.json with "7.0.0"?

"version": "0.0.0-semantically-released",

@voxpelli
Copy link
Member Author

@ota-meshi Good point, fixed!

@voxpelli voxpelli force-pushed the voxpelli/issue506 branch from cb7f116 to 6d145b8 Compare July 24, 2024 10:59
@ota-meshi
Copy link
Member

The linting error should be fixed in #507.

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the release-please config but it looks good to me. Thanks!

@voxpelli
Copy link
Member Author

I'm not familiar with the release-please config but it looks good to me. Thanks!

Its copied from eslint-plugin-n and neostandard :)

@voxpelli voxpelli merged commit e1ce2ad into main Jul 24, 2024
11 checks passed
@brettz9
Copy link
Member

brettz9 commented Jul 24, 2024

I'm not familiar with the release-please config but it looks good to me. Thanks!

Likewise...

@voxpelli voxpelli deleted the voxpelli/issue506 branch July 24, 2024 11:16
voxpelli added a commit that referenced this pull request Jul 24, 2024
**What is the purpose of this pull request?**

To assist #508 / #506 by ensuring that PR-title's are always valid
conventional commit format before merging

**What changes did you make? (Give an overview)**

Added a pinned
[mtfoley/pr-compliance-action](https://github.com/mtfoley/pr-compliance-action)
similar to what I use at eg. neostandard:
https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap release process to release-please
4 participants