-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: swap release process to release-please #508
Conversation
Do you think we also need to replace the version in package.json with eslint-plugin-promise/package.json Line 3 in 602d825
|
@ota-meshi Good point, fixed! |
cb7f116
to
6d145b8
Compare
The linting error should be fixed in #507. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the release-please config but it looks good to me. Thanks!
Its copied from |
Likewise... |
**What is the purpose of this pull request?** To assist #508 / #506 by ensuring that PR-title's are always valid conventional commit format before merging **What changes did you make? (Give an overview)** Added a pinned [mtfoley/pr-compliance-action](https://github.com/mtfoley/pr-compliance-action) similar to what I use at eg. neostandard: https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml
What is the purpose of this pull request?
To improve the release process by swapping to release-please. Fixes #506
What changes did you make? (Give an overview)
Removed
cycjimmy/semantic-release-action
and addedgoogleapis/release-please-action