feat(indent-binary-ops): disabled to lower indent when starts closing…

… bracket (#591)
eslint-stylistic · Nov 1, 2024 · 25fe554 · 25fe554
1 parent 6000f43
commit 25fe554
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 5 deletions.
diff --git a/packages/eslint-plugin/rules/indent-binary-ops/indent-binary-ops._plus_.test.ts b/packages/eslint-plugin/rules/indent-binary-ops/indent-binary-ops._plus_.test.ts
@@ -336,4 +336,34 @@ it('snapshots', async () => {
         || (g && h)
     }"
   `)
+
+  expect.soft(
+    fix($`
+      type Type =
+        | ({
+          type: 'a';
+        } & A)
+        | ({
+          type: 'b';
+          } & B)
+        | ({
+          type: 'c';
+        } & {
+          c: string;
+        });
+    `),
+  ).toMatchInlineSnapshot(`
+    "type Type =
+      | ({
+        type: 'a';
+      } & A)
+      | ({
+        type: 'b';
+        } & B)
+        | ({
+        type: 'c';
+      } & {
+        c: string;
+      });"
+  `)
 })
diff --git a/packages/eslint-plugin/rules/indent-binary-ops/indent-binary-ops._plus_.ts b/packages/eslint-plugin/rules/indent-binary-ops/indent-binary-ops._plus_.ts
@@ -83,10 +83,6 @@ export default createRule<RuleOptions, MessageIds>({
       return openBracketCount < closeBracketCount
     }
 
-    function hasExclusivelyCloseBracketOfLine(line: number) {
-      return !sourceCode.tokensAndComments.some(token => token.loc.start.line === line && ![')', '}', ']'].includes(token.value))
-    }
-
     function handler(node: ASTNode, right: ASTNode) {
       if (node.loc.start.line === node.loc.end.line)
         return
@@ -128,7 +124,7 @@ export default createRule<RuleOptions, MessageIds>({
         || (
           lastTokenOfLineLeft?.value === ')'
           && isGreaterThanCloseBracketOfLine(tokenLeft.loc.start.line)
-          && !hasExclusivelyCloseBracketOfLine(tokenLeft.loc.start.line)
+          && ![']', ')', '}'].includes(firstTokenOfLineLeft?.value || '')
         )
 
       const indentLeft = getIndentOfLine(tokenLeft.loc.start.line)