Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: New package tool #145

Merged
merged 7 commits into from
Feb 3, 2025
Merged

chore: New package tool #145

merged 7 commits into from
Feb 3, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 28, 2025

Prerequisites checklist

What is the purpose of this pull request?

Creates a tool that bootstraps a new package in the monorepo.

What changes did you make? (Give an overview)

  • Added tools/new-pkg.js
  • Added a package template directory

Related Issues

Is there anything you'd like reviewers to focus on?

I set the root package.json Node.js version to v22.3 so I could use some of the newer Node.js utilities for this, but let me know if that's a problem.

@nzakas nzakas force-pushed the new-pkg-tool branch 2 times, most recently from a418db0 to 9be9c2f Compare January 28, 2025 00:13
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the formatting error.

@nzakas
Copy link
Member Author

nzakas commented Jan 29, 2025

I realized there's nothing package-specific about the build-cts.js tool, so I moved it to the top level to avoid duplication. I also went through and updated all of the packages with CommonJS to use it as I think we probably have issues there too.

Edit: Split those changes out into a separate PR:
#148

Once that's merged, I'll rebase this PR on top of that.

@nzakas nzakas marked this pull request as draft January 29, 2025 18:05
@nzakas nzakas marked this pull request as ready for review January 31, 2025 17:47
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 973144e into main Feb 3, 2025
18 checks passed
@mdjermanovic mdjermanovic deleted the new-pkg-tool branch February 3, 2025 19:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants