Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose embedded-svc/use_serde feature #558

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

EmrysMyrddin
Copy link
Contributor

@EmrysMyrddin EmrysMyrddin commented Feb 1, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

The embedded-svc crate have a use_serde feature, which is not enabled by default. To enable it, it have to be propagated from this crate.

This feature is handy when dealing with configuration. In my use case, I use it to parse to have a simple json file for my wifi configuration.

Testing

It's a simple cargo feature flag.

@EmrysMyrddin EmrysMyrddin marked this pull request as ready for review February 1, 2025 14:03
@EmrysMyrddin EmrysMyrddin changed the title Expose embedded-svc/use_serde feature Expose embedded-svc/use_serde feature Feb 1, 2025
@ivmarkov
Copy link
Collaborator

ivmarkov commented Feb 1, 2025

Makes perfect sense, thanks!

@ivmarkov ivmarkov merged commit 4ccf318 into esp-rs:master Feb 1, 2025
20 checks passed
@EmrysMyrddin
Copy link
Contributor Author

Wow ! Thank you for your reactivity :-)
I'm new to Rust and ESP programming, but the work all of you did on esp-rs is incredible!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants