-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
POST http client example #2704
Merged
earlephilhower
merged 10 commits into
esp8266:master
from
jamesmarlowe:posthttpclientexample
Dec 11, 2019
Merged
POST http client example #2704
earlephilhower
merged 10 commits into
esp8266:master
from
jamesmarlowe:posthttpclientexample
Dec 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 27.80% (diff: 100%)@@ master #2704 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
Thanks for this example, i was looking for a working ino file. +1 👍 |
Simple example, but needs to be updated to use the new HTTPClient interface, not the deprecated one. I think it can be in for 2.6.0. If not, just drop it completely. |
This needs to be looked at and tested. Pushing back, |
d-a-v
approved these changes
Dec 8, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought an example using POST might be useful as per #2678