Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for concatenation of headers #4864

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Support for concatenation of headers #4864

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0ba7ad
support for concatenation of headers
Jun 29, 2018
8dff51e
Merge branch 'master' into master
earlephilhower Oct 3, 2018
387a514
Use commas and only when needed
earlephilhower Oct 3, 2018
72e7f45
Merge branch 'master' into master
earlephilhower Oct 4, 2018
671fdb9
Merge branch 'master' into master
earlephilhower Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ int HTTPClient::handleHeaderResponse()

for(size_t i = 0; i < _headerKeysCount; i++) {
if(_currentHeaders[i].key.equalsIgnoreCase(headerName)) {
_currentHeaders[i].value = headerValue;
_currentHeaders[i].value += headerValue + ";";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we follow the HTTP spec and use a , instead for concatenation?

RFC 2616

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the , A comma is definitely the expected concatenation character.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks like this is going to mess up the default, single-header case by adding an illegal/unneeded ";" (or "," once fixed to match RFC 2616) to all values.

break;
}
}
Expand Down