Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update HTTPCLIENT_1_1_COMPATIBLE #5389

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 29, 2018

use #if instead of #ifdef, set to 1 by default
(set to 0 in host emulation where axTLS is unavailable)

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

make D=1 ../../libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer
make D=1 ../../libraries/ESP8266mDNS/examples/mDNS_Web_Server/mDNS_Web_Server
make D=1 ../../libraries/ESP8266WiFi/examples/BearSSL_Validation/BearSSL_Validation
make -j D=1 ../../libraries/ESP8266WiFi/examples/udp/udp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember saying -j would auto-scale the jobs, but it turns out I was wrong. -j will run as many jobs in parallel as make can figure out. It's not really an issue for a single compile like this as most folks will have at least 2-4 cores if they're doing this.

-j [jobs], --jobs[=jobs]
     Specifies the number of jobs (commands) to run simultaneously.  If there is more
     than one -j option, the last one is effective.  If the -j option is given  with‐
     out  an argument, make will not limit the number of jobs that can run simultane‐
     ously. When make invokes a sub-make, all instances of make  will  coordinate  to
     run  the  specified  number of jobs at a time; see the section PARALLEL MAKE AND
     THE JOBSERVER for details.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember saying -j

I took your wise word :)

@earlephilhower earlephilhower merged commit 116da18 into esp8266:master Nov 29, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants