Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI: fix style checking #7222

Merged
merged 3 commits into from
Apr 18, 2020
Merged

CI: fix style checking #7222

merged 3 commits into from
Apr 18, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Apr 17, 2020

  • (some) core files are astyled
  • ci was only checking libraries/

=> now everything is checked

d-a-v added 2 commits April 17, 2020 23:11
@d-a-v
fix style checking:
329790f 
- (some) core files are astyled
- ci was only checking libraries
=> now everything is checked
@d-a-v
Merge branch 'master' into styleCIfix
ae4e3fa
devyte
devyte approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a glance

@devyte devyte merged commit ce0e63f into esp8266:master Apr 18, 2020
earlephilhower
earlephilhower approved these changes Apr 18, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devyte devyte added this to the 2.7.0 milestone Apr 18, 2020
@earlephilhower
Copy link
Collaborator

Missed it by that much. 😆

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@earlephilhower earlephilhower

@devyte devyte

Assignees
No one assigned
Labels
component: core type: code cleanup
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @earlephilhower @devyte