Update from comments

libraries/Netdump/examples/Netdump/Netdump.ino

@@ -29,26 +29,26 @@ File             tracefile;
 
 std::map<PacketType, int> packetCount;
 
-enum SerialOption {
+enum class SerialOption : uint8_t {
   AllFull,
   LocalNone,
   HTTPChar
 };
 
-void startSerial(int option) {
+void startSerial(SerialOption option) {
   switch (option) {
-    case AllFull : //All Packets, show packet summary.
+    case SerialOption::AllFull : //All Packets, show packet summary.
       nd.printDump(Serial, Packet::PacketDetail::FULL);
       break;
 
-    case LocalNone : // Only local IP traffic, full details
+    case SerialOption::LocalNone : // Only local IP traffic, full details
       nd.printDump(Serial, Packet::PacketDetail::NONE,
       [](Packet n) {
         return (n.hasIP(WiFi.localIP()));
       }
                   );
       break;
-    case HTTPChar : // Only HTTP traffic, show packet content as chars
+    case SerialOption::HTTPChar : // Only HTTP traffic, show packet content as chars
       nd.printDump(Serial, Packet::PacketDetail::CHAR,
       [](Packet n) {
         return (n.isHTTP());
@@ -79,7 +79,7 @@ void setup(void) {
   WiFi.begin(ssid, password);
 
   if (WiFi.waitForConnectResult() != WL_CONNECTED) {
-    Serial.println("WiFi Failed");
+    Serial.println("WiFi Failed, stopping sketch");
     while (1) {
       delay(1000);
     }
@@ -122,7 +122,7 @@ void setup(void) {
   webServer.serveStatic("/", *filesystem, "/");
   webServer.begin();
 
-  startSerial(AllFull); // Serial output examples, use enum SerialOption for selection
+  startSerial(SerialOption::AllFull); // Serial output examples, use enum SerialOption for selection
 
   //  startTcpDump();     // tcpdump option
   //  startTracefile();  // output to SPIFFS or LittleFS

libraries/Netdump/src/Netdump.cpp

@@ -89,7 +89,7 @@ void Netdump::tcpDump(WiFiServer &tcpDumpServer, const Filter nf)
 
     if (!packetBuffer)
     {
-        packetBuffer = new char[tcpBuffersize];
+        packetBuffer = new char[tcpBufferSize];
     }
     bufferIndex = 0;
 
@@ -162,7 +162,7 @@ void Netdump::tcpDumpProcess(const Packet& np)
     }
     size_t incl_len = np.getPacketSize() > maxPcapLength ? maxPcapLength : np.getPacketSize();
 
-    if (bufferIndex + 16 + incl_len < tcpBuffersize) // only add if enough space available
+    if (bufferIndex + 16 + incl_len < tcpBufferSize) // only add if enough space available
     {
         struct timeval tv;
         gettimeofday(&tv, nullptr);

libraries/Netdump/src/Netdump.h

@@ -77,7 +77,7 @@ class Netdump
     char* packetBuffer = nullptr;
     size_t bufferIndex = 0;
 
-    static constexpr int tcpBuffersize = 2048;
+    static constexpr int tcpBufferSize = 2048;
     static constexpr int maxPcapLength = 1024;
     static constexpr uint32_t pcapMagic = 0xa1b2c3d4;
 };

libraries/Netdump/src/NetdumpIP.cpp

@@ -28,10 +28,6 @@ NetdumpIP::NetdumpIP()
 {
 }
 
-NetdumpIP::~NetdumpIP()
-{
-}
-
 NetdumpIP::NetdumpIP(uint8_t first_octet, uint8_t second_octet, uint8_t third_octet, uint8_t fourth_octet)
 {
     setV4();

libraries/Netdump/src/NetdumpIP.h

@@ -20,7 +20,6 @@ class NetdumpIP
 {
 public:
     NetdumpIP();
-    ~NetdumpIP();
 
     NetdumpIP(uint8_t first_octet, uint8_t second_octet, uint8_t third_octet, uint8_t fourth_octet);
     NetdumpIP(const uint8_t *address, bool V4 = true);

libraries/Netdump/src/NetdumpPacket.h

@@ -43,8 +43,6 @@ class Packet
         setPacketTypes();
     };
 
-    Packet() {};
-
     enum class PacketDetail
     {
         NONE,

libraries/Netdump/src/PacketType.cpp

@@ -14,10 +14,6 @@ PacketType::PacketType()
 {
 }
 
-PacketType::~PacketType()
-{
-}
-
 String PacketType::toString() const
 {
     switch (ptype)

libraries/Netdump/src/PacketType.h

@@ -41,8 +41,6 @@ class PacketType
     PacketType();
     PacketType(PType pt) : ptype(pt) {};
 
-    ~PacketType();
-
     operator PType() const
     {
         return ptype;