Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MDNS MultiInterface #7636

Merged
merged 6 commits into from
Oct 15, 2020
Merged

MDNS MultiInterface #7636

merged 6 commits into from
Oct 15, 2020

Conversation

hreintke
Copy link
Contributor

@hreintke hreintke commented Oct 6, 2020

No description provided.

devyte
devyte approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one comment here is: I see very few comments in the changed code. If at all possible, please add. comments explaining what the code lines do.
Approved.

@earlephilhower earlephilhower merged commit 9003b02 into esp8266:master Oct 15, 2020
davisonja added a commit to davisonja/Arduino that referenced this pull request Oct 16, 2020
@davisonja
Merge branch 'master' into ota_commands_in_flash
4d64292 
* master: (37 commits)
  BREAKING: Change return EEPROM.end() to bool (esp8266#7630)
  BREAKING: Change return type of channel() (esp8266#7656)
  BREAKING: Change return type of RSSI() (esp8266#7657)
  Add Copyright notice to Schedule.h (esp8266#7653)
  MDNS MultiInterface (esp8266#7636)
  BREAKING: Add Wrong Password wifi status case (esp8266#7652)
  New flash writing method with offset/memory/size alignment handling (esp8266#7514)
  Fix error when debug enabled but no port chosen (esp8266#7648)
  LEAmDNSv2: change a macro name to be independant from LEAmDNS1 (esp8266#7640)
  Allow test framework to use cores/esp8266/Arduino.h directly (esp8266#7377)
  Update OTA HTTP Server Header Information (esp8266#7633)
  Add missing sntp_init/sntp_stop (esp8266#7628)
  Use direct member initialization instead of ctr initialisation (esp8266#7558)
  Prevent rewriting Updater_Signing.h if content unchanged (esp8266#7627)
  Add WiFi Multi to readme.rst
  Remove stray axtls refs, deprecated compat funcs (esp8266#7626)
  Pull deprecated axtls link (esp8266#7624)
  Redesign ESP8266WiFiMulti.[cpp|h]
  Update README.md (esp8266#7623)
  Eliminate code duplication by template for printNumber(...)/printFloat(...).
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@d-a-v d-a-v

@devyte devyte

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hreintke @d-a-v @devyte @earlephilhower