Skip to content

Added ESP32 compatible methods for setting/getting hostname #7900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

Added ESP32 compatible methods for setting/getting hostname #7900

merged 2 commits into from
Mar 3, 2021

Conversation

drzony
Copy link
Contributor

@drzony drzony commented Mar 1, 2021

As discussed with @d-a-v

d-a-v
d-a-v approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower merged commit 22442f0 into esp8266:master Mar 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drzony @earlephilhower @d-a-v