feat: adding possibility to manually set MD5 checksum for HTTP update #8204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
requested changes
Jul 9, 2021
vlastahajek
force-pushed
the
feat/updater-custom-md5
branch
from
eac1645
to
ba01b70
Compare
|
@earlephilhower, thanks for the quick and detailed review. I've fixed the wrong merge of the locally modified file. |
earlephilhower
approved these changes
Jul 11, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a library that allows updating from Github releases. To verify firmware integrity HTTPUpdater already supports MD5 checksum, but is only read from the server response header. This is not possible if there is no control of the server.
If a checksum is known from another source, it is not possible to set it. This PR allows this.