Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Place deprecated attribute in front of function #8258

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Place deprecated attribute in front of function #8258

merged 2 commits into from
Sep 1, 2021

Conversation

oxan
Copy link
Contributor

@oxan oxan commented Aug 6, 2021

This is the standards-compliant way to mark functions as deprecated (see https://en.cppreference.com/w/cpp/language/attributes/deprecated).

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just so many ways to get from A to B in C++ it kind of makes one's head spin. This change LGTM.

@earlephilhower earlephilhower merged commit fb5c4a6 into esp8266:master Sep 1, 2021
@oxan oxan deleted the patch-1 branch September 1, 2021 16:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants