Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

emulation on host: minor updates #8454

Merged
merged 7 commits into from
Feb 20, 2022
Merged

emulation on host: minor updates #8454

merged 7 commits into from
Feb 20, 2022

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 18, 2022

  • Merge MockDigital.cpp and HostWiring.cpp
    one is used for CI, the other for emulation on host
  • other minor fixes

@mcspr
Copy link
Collaborator

mcspr commented Jan 19, 2022

Formatting broke somewhere? Some things are tabs, some are 2sp, some are 4sp.
Just to avoid another extern, can't it install a certain func that either does nothing or prints things?
i.e. mock_verbose_func(nullptr) (or, [](const char*, ...) {}) to disable log, mock_verbose_func([](const char* fmt, ...) { ... do stuff ... }); to enable

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jan 19, 2022

Formatting broke somewhere? Some things are tabs, some are 2sp, some are 4sp.

#8455#8464 will fix this.

@d-a-v d-a-v requested a review from mcspr January 29, 2022 12:23
@d-a-v d-a-v added the alpha included in alpha release label Jan 29, 2022
@mcspr mcspr merged commit 15e7d35 into esp8266:master Feb 20, 2022
@d-a-v d-a-v deleted the mockminors branch February 20, 2022 21:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha included in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants