Catch a possible null-dereference #8508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing, I had an HTTP server that would server a 200 OK header, then crash, killing the connection.
The result was an exception in HTTPUpdater, which turned out to be due to passing a null pointer to
WiFiClient::stopAllExcept
In catching this, I've chosen to return
HTTPC_ERROR_CONNECTION_LOST
. This is an HTTPClient definition, rather than an HTTPUpdate one, which makes me a little uneasy. I've justified it to myself on the basis that:/// note we use HTTP client errors too [...]