Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid reading past end of non-zero terminated char arrays #8597

Merged
merged 2 commits into from
Jun 12, 2022
Merged

Avoid reading past end of non-zero terminated char arrays #8597

merged 2 commits into from
Jun 12, 2022

Conversation

paulocsanz
Copy link
Contributor

@paulocsanz paulocsanz commented Jun 12, 2022 •
edited
Loading

Some char* passed may be non-zero terminated slices, we could both endup with a non-zero terminated String and read past the end of the allocation, so on unmapped memory (or even possibly flash memory).

This fixes the issue.

@mcspr mcspr added this to the 3.1 milestone Jun 12, 2022
@d-a-v d-a-v merged commit bdc71e5 into esp8266:master Jun 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@d-a-v d-a-v d-a-v left review comments

@mcspr mcspr mcspr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulocsanz @mcspr @d-a-v