Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add httpupdate lib import in ota documentation #8667

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

amjed-ali-k
Copy link
Contributor

Docs doesn't include any reference to include <ESP8266httpUpdate.h> library in Advanced OTA Updater section. It took me some time to find out while reading the docs

Docs doesn't include any reference to include <ESP8266httpUpdate.h> library in Advanced OTA Updater section. It took me some time to find out while reading the docs
@d-a-v d-a-v changed the title Add httpupdate lib import in ota example Add httpupdate lib import in ota documentation Sep 13, 2022
@d-a-v d-a-v merged commit 9cd560b into esp8266:master Dec 14, 2022
@DarioGHub
Copy link
Contributor

@amjed-ali-k I may not understand your motivation, but a lesson I learned was that "docs" include the examples. Given that the examples use the line #include <ESP8266httpUpdate.h>, how is it helpful to add that line twice more to readme.rst? Perhaps you would like to clarify the need.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants