Nice stack smashing postmortem message #8670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire everything that relies on stack smashing detection to call
__stack_chk_fail()
(aka what libssp / ssp / stack-protector uses) Expose it in our debugging headerRename overflow -> smashing, as these are different things we are trying to detect (meaning, that we check for things writing there, not some kind of
alloca
issue or the way-fstack-check
would have worked) ref. #8666-fstack-protector
continues to work as it always did CONT replacesabort()
, also moves its check to the loop wrapper to avoid dumping otherwise useless SYS context memory StackThunk replaces a similarabort()
call