Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NONOS SDK clean-up #8770

Merged
merged 10 commits into from
Jan 2, 2023
Merged

NONOS SDK clean-up #8770

merged 10 commits into from
Jan 2, 2023

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Dec 21, 2022

Remove nonos-sdk-v2.2.0-28-g89920dc aka 3v0 (per matrix proposal), since we have a real v3
Remove 3.0.0...3.0.4 to reduce overhead in maintaining a bunch or binary patches
Update our docs and menu opts to mention 'experimental' status

I believe 3v0 support was treated as 'experimental', so this is a non breaking change?
Not sure why we refer to NONOS as 'Espressif Fw / Firmware', maybe also rename it?
Old versions still remains in git history, so anyone wanting to play around with 3.0.x could still make use of that work

(edit by @d-a-v)
Closes #5784

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • 2.5K lines made unnecessary is always good

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 21, 2022

I believe 3v0 support was treated as 'experimental', so this is a non breaking change?

Yes

Not sure why we refer to NONOS as 'Espressif Fw / Firmware', maybe also rename it?

Agreed

@d-a-v d-a-v added the alpha included in alpha release label Dec 31, 2022
@d-a-v d-a-v added this to the 3.1 milestone Dec 31, 2022
@mcspr mcspr merged commit 204d2c9 into esp8266:master Jan 2, 2023
@mcspr mcspr deleted the 3v0-remove branch January 2, 2023 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha included in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK issues (SDK reverted from pre3 to 2.2.1)
2 participants