Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(littlefs): Add missing dependency #10496

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

clashman
Copy link
Contributor

This is a mandatory depedency of the LittleFS library. Without this fix the library won't compile with idf component manager is disabled.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello clashman, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9d6259f

@VojtechBartoska VojtechBartoska added the Area: Libraries Issue is related to Library support. label Oct 22, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 22, 2024
@me-no-dev me-no-dev merged commit 4944dd0 into espressif:master Oct 22, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants