Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for esp32c6 #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for esp32c6 #34

wants to merge 1 commit into from

Conversation

ptxmac
Copy link

@ptxmac ptxmac commented Jan 12, 2025

Description

A minor fix so esp-idf-cxx can compile correctly for esp32c6 (and maybe other?)

i2c_cxx incorrectly assumed that I2C_NUM_1 would exist if SOC_I2C_NUM >= 2. But that's not the case when the device has 1 HP i2c and 1 LP i2c.

This changes i2c_cxx to look at only the HP SOC_HP_I2C_NUM instead

Testing

My own code compiles now 😄


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2025

CLA assistant check
All committers have signed the CLA.

@ptxmac
Copy link
Author

ptxmac commented Jan 14, 2025

Tests fails for unrelated reasons

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants