-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[lws]: Add initial support for libwebsockets #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91c836c
to
b900029
Compare
05aca45
to
860ee1e
Compare
components/libwebsockets/examples/client-echo/main/lws-client-echo.c
Outdated
Show resolved
Hide resolved
components/libwebsockets/examples/client-echo/main/lws-client-echo.c
Outdated
Show resolved
Hide resolved
components/libwebsockets/examples/client-echo/main/CMakeLists.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall!
4f493f5
to
ef3443d
Compare
david-cermak
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just left a few minor comments or questions.
46b58c9
to
6a9254b
Compare
e71e773
to
cf4af07
Compare
d2e9eb3
to
48856e6
Compare
euripedesrocha
requested changes
Feb 18, 2025
4.3.3 Features - Add initial support libwebsockets component (ef3443d)
euripedesrocha
approved these changes
Feb 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description