Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[lws]: Add initial support for libwebsockets #718

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

glmfe
Copy link
Collaborator

@glmfe glmfe commented Dec 19, 2024

Description

  • Add libwebsockets as component
  • Created simple client example
  • Created simple server echo example

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024

CLA assistant check
All committers have signed the CLA.

@glmfe glmfe changed the title Add libwebsockets as component [libwebsockets]: Add initial support for libwebsockets Jan 29, 2025
@glmfe glmfe force-pushed the feat/lws branch 3 times, most recently from 91c836c to b900029 Compare January 29, 2025 20:38
@glmfe glmfe self-assigned this Jan 29, 2025
@glmfe glmfe added the lws libwebsockets label Jan 29, 2025
@glmfe glmfe changed the title [libwebsockets]: Add initial support for libwebsockets [lws]: Add initial support for libwebsockets Jan 29, 2025
@glmfe glmfe force-pushed the feat/lws branch 6 times, most recently from 05aca45 to 860ee1e Compare January 30, 2025 03:52
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall!

@glmfe glmfe marked this pull request as ready for review January 31, 2025 01:53
@glmfe glmfe force-pushed the feat/lws branch 4 times, most recently from 4f493f5 to ef3443d Compare February 5, 2025 14:07
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just left a few minor comments or questions.

@glmfe glmfe force-pushed the feat/lws branch 3 times, most recently from 46b58c9 to 6a9254b Compare February 7, 2025 21:28
@glmfe glmfe force-pushed the feat/lws branch 3 times, most recently from e71e773 to cf4af07 Compare February 8, 2025 14:38
@glmfe glmfe force-pushed the feat/lws branch 3 times, most recently from d2e9eb3 to 48856e6 Compare February 11, 2025 12:04
@glmfe glmfe merged commit c679cee into espressif:master Feb 19, 2025
43 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lws libwebsockets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants