Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[mdns]: Allow allocate memory with configured caps #764

Merged
merged 4 commits into from
Feb 18, 2025
Merged

[mdns]: Allow allocate memory with configured caps #764

merged 4 commits into from
Feb 18, 2025

Conversation

david-cermak
Copy link
Collaborator

Addresses IDF-11680: Add a config and a mechanism to support allocating memory from PSRAM for mDNS service.

@david-cermak david-cermak self-assigned this Feb 13, 2025
@david-cermak david-cermak force-pushed the feat/mdns_malloc_caps branch 3 times, most recently from e25de59 to 21737bb Compare February 13, 2025 13:58
@david-cermak
Copy link
Collaborator Author

@zwx1995esp PTAL, not sure how to approach coexistence of MDNS_TASK_MEMORY_ALLOC_FROM and MDNS_MEMORY_ALLOC_FROM or define a dependency between?
so far added them as two separate configs, but open for discussion.

zwx1995esp
zwx1995esp approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@zwx1995esp zwx1995esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot for such quick support.

@zwx1995esp
Copy link
Collaborator

zwx1995esp commented Feb 14, 2025 •
edited
Loading

Not sure how to approach coexistence of MDNS_TASK_MEMORY_ALLOC_FROM and MDNS_MEMORY_ALLOC_FROM or define a dependency between? so far added them as two separate configs, but open for discussion.

Hi, David, I think we could keep both configurations for the user. If the task is created in internal memory, it can save some time during system task switching.

@david-cermak david-cermak force-pushed the feat/mdns_malloc_caps branch 2 times, most recently from f52c394 to 91fc7c3 Compare February 14, 2025 14:36
zwx1995esp
zwx1995esp approved these changes Feb 17, 2025
View reviewed changes
@david-cermak
feat(mdns): Support user defined allocators
88162d1 
Defines mem-alloc function optionally weak, so users can override them
and implement their own allocation, or a static/bss memory for the mdns
task stack.
@david-cermak
bump(mdns): 1.6.0 -> 1.7.0
384d1c2 
1.7.0
Features
- Support user defined allocators (88162d1)
- Allow allocate memory with configured caps (7d29b47)
Bug Fixes
- Adjust some formatting per indent-cont=120 (5b2077e)
@david-cermak david-cermak merged commit dea5f1c into espressif:master Feb 18, 2025
50 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zwx1995esp zwx1995esp zwx1995esp approved these changes

@euripedesrocha euripedesrocha Awaiting requested review from euripedesrocha

Assignees

@david-cermak david-cermak

Labels
mdns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-cermak @zwx1995esp