Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix right column & row of the measure window #588

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix right column & row of the measure window #588

merged 2 commits into from
Nov 10, 2023

Conversation

larryli
Copy link
Contributor

@larryli larryli commented Oct 24, 2023 •
edited
Loading

Measure Window

Address Name Width Default Value R/W Description
P0:0xf7 Big_win_x0 6 0x04 RW Measure big window left column number, X4
P0:0xf8 Big_win_y0 6 0x02 RW Measure big window left row number, X4
P0:0xf9 Big_win_x1 8 0x98 RW Measure big window right column number, X4
P0:0xfa Big_win_y1 8 0x70 RW Measure big window right row number, X4

GC0308 DataSheet 27 / 32

@me-no-dev
Copy link
Member

@WangYuxin-esp can you please confirm this change?

@WangYuxin-esp
Copy link
Contributor

@WangYuxin-esp can you please confirm this change?

Yes, I have reviewed the relevant technical manual and added testing, and this fix is correct.

@me-no-dev me-no-dev merged commit dba8da9 into espressif:master Nov 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larryli @me-no-dev @WangYuxin-esp