Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option to customize JPEG mode frame size in menuconfig #667

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

maruta
Copy link
Contributor

@maruta maruta commented Jul 14, 2024

This Pull Request provides an option in menuconfig to customize the buffer size for JPEG mode, addressing Issue #663.

  • Added a configurable option in Kconfig to choose between the default automatic calculation (width * height / 5) and specifying a custom buffer size.
  • The default setting maintains the existing behavior, so it should not affect current code. However, please review carefully as I am not very experienced with this library.

@maruta
Copy link
Contributor Author

maruta commented Jul 16, 2024

I apologize for the mistake in the initial pull request. I have just corrected the code and pushed the new commits.

@me-no-dev
Copy link
Member

I would only suggest to replace "receive size" with "frame size" or "image file size" to make it clear what size is actually being set. "receive size" is a bit ambiguous

@maruta maruta changed the title Add option to customize JPEG mode receive size in menuconfig Add option to customize JPEG mode frame size in menuconfig Jul 16, 2024
@maruta
Copy link
Contributor Author

maruta commented Jul 16, 2024

@me-no-dev
I agree. I have updated the request and corrected the commit. Thank you for your suggestion.

driver/cam_hal.c Outdated Show resolved Hide resolved
@me-no-dev me-no-dev merged commit 7aa37d4 into espressif:master Jul 16, 2024
24 checks passed
@me-no-dev
Copy link
Member

Thanks @maruta :) It now works

@maruta
Copy link
Contributor Author

maruta commented Jul 16, 2024

@me-no-dev
Sorry for the oversight. Thanks for your patience!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants