Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(xclk): Zero init ledc_channel_config_t for forward compatibility #702

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tore-espressif
Copy link
Contributor

@tore-espressif tore-espressif commented Nov 15, 2024

Description

LEDC driver was extended in espressif/esp-idf@4a90deb with new config structure members. We must zero init the config struct to get default behavior.

Related

Testing

Run esp32-camera example on S2 board.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

LEDC driver was extended in espressif/esp-idf@4a90deb with new config structure members.
We must zero init the config struct to get default behavior.
@tore-espressif
Copy link
Contributor Author

@me-no-dev PTAL! It would be good to release new esp32-camare soon, as it does not work with latest esp-idf master on S2

@me-no-dev me-no-dev merged commit 10e6178 into espressif:master Nov 15, 2024
25 checks passed
@me-no-dev
Copy link
Member

merged and released 2.0.14

@tore-espressif tore-espressif deleted the patch-1 branch November 15, 2024 08:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants