all apps: refactor global. -> globalThis.
#3763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per: [global is used in Node.js. Consider using the identical globalThis as it was introduced in the ECMAScript spec.](https://www.espruino.com/ReferenceBANGLEJS2#l__global_global) If we decide it's worth merging this we should probably bump versions of the apps as well?
|
Thanks, but I'm not really sure if this adds anything? It'll make all these apps very slightly larger and slower and introduces the possibility of breakage. But otherwise it's not fixing anything, just following what the ECMA spec team randomly changed. Looking at Node.js specs it says ... perhaps the wording in |
Yes that makes sense to me in that case 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per:
global is used in Node.js. Consider using the identical globalThis as it was introduced in the ECMAScript spec.
If we decide it's worth merging this we should probably bump versions of the apps as well?
@bobrippling @gfwilliams Does this make sense?