Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

voldisp: new app that displays volume change on Android device #3780

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

thyttan
Copy link
Collaborator

@thyttan thyttan commented Mar 19, 2025

Display the media volume of your android device when it's changed. A bar shows up at the top of your Bangles screen. (Needs recent Gadgetbridge nightly or stable ver. 85 once out)

Copy link
Collaborator

@bobrippling bobrippling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! Just a few little things

@thyttan
Copy link
Collaborator Author

thyttan commented Mar 20, 2025

@thyttan:

Yes it felt unnecessary to bake in the hundred lines for the swipeOn functionality trough a require call.

Come to think of it - I didn't consider handing swipeOn-widgets.. But maybe it's covered anyway 🤔

No, I don't think swipeOn widgets are covered. If they are used by the app we currently end up replacing them with always showing widgets I believe.

Any idea of if there's a solution to discern the difference of if widgets are just hidden or are swipeOn-ed? I'm having trouble coming up with anything that's already available. We can always implement some identifying variable I guess though.

I kind of feel like skipping all this robust hiding widgets logic and just let widgets occasionally draw over the volume bar if they happen to do that.. 😅

@bobrippling
Copy link
Collaborator

No, I don't think swipeOn widgets are covered. If they are used by the app we currently end up replacing them with always showing widgets I believe.

Yeah I think that should be ok with your latest commit (1fa489b) too, nice idea

Any idea of if there's a solution to discern the difference of if widgets are just hidden or are swipeOn-ed? I'm having trouble coming up with anything that's already available. We can always implement some identifying variable I guess though.

I kind of feel like skipping all this robust hiding widgets logic and just let widgets occasionally draw over the volume bar if they happen to do that.. 😅

Yeah same - I think what we have now is ok and we can always address it if the widget drawing is a problem in the future. I can think of a way or two to address it but let's see if it's worth the complexity.

Happy to merge as-is, or if you want to back out any of those latest commits for doing some of this, go for it

@thyttan
Copy link
Collaborator Author

thyttan commented Mar 21, 2025

Yeah I just reverted the widget handling stuff now. So happy to have it merged :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants