-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
voldisp: new app that displays volume change on Android device #3780
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good! Just a few little things
Hopefully. And also, probably not needed...
Also small optimization.
No, I don't think swipeOn widgets are covered. If they are used by the app we currently end up replacing them with always showing widgets I believe. Any idea of if there's a solution to discern the difference of if widgets are just hidden or are I kind of feel like skipping all this robust hiding widgets logic and just let widgets occasionally draw over the volume bar if they happen to do that.. 😅 |
Yeah I think that should be ok with your latest commit (1fa489b) too, nice idea
Yeah same - I think what we have now is ok and we can always address it if the widget drawing is a problem in the future. I can think of a way or two to address it but let's see if it's worth the complexity. Happy to merge as-is, or if you want to back out any of those latest commits for doing some of this, go for it |
Yeah I just reverted the widget handling stuff now. So happy to have it merged :) |
Display the media volume of your android device when it's changed. A bar shows up at the top of your Bangles screen. (Needs recent Gadgetbridge nightly or stable ver. 85 once out)