Function for #589 and comment removals #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! With the comments, I'm not against you adding them at all - it's really good. I just want to make sure that if there are comments in the header file and the C file, that they're both saying the same thing. |
gfwilliams
added a commit
that referenced
this pull request
Oct 28, 2015
Function for #589 and comment removals
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #589 adds a generic WiFi interface. This pull-request adds support for a wifi.connect() option called dnsServers. When we connect to the WiFi access point, we can supply a property called "dnsServers" which is an array of up to two IP addresses which will be the DNS servers to use as opposed to being DHCP satisfied.
This Pull Request also undoes some comments added to network.c.