Issue #589. Design and implementation of wifi.getStatus() #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| params[1] = jsAccessPointArray; | ||
| jsiQueueEvents(NULL, g_jsScanCallback, params, 2); | ||
|
|
||
| jsvUnLock(jsAccessPointArray); |
There was a problem hiding this comment.
Minor thing here, you can always use jsvUnlock3 to unlock a bunch at once. It's not such an issue on ESP8266, but it actually saves a bunch of code space when it's done on other platforms.
|
This looks really good - thanks! |
gfwilliams
added a commit
that referenced
this pull request
Nov 2, 2015
Issue #589. Design and implementation of wifi.getStatus()
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PullRequest introduces the generic wifi function called
getStatus().