Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

why are csv_dd and flmd templates in xlsx format? #3

Closed
regnans opened this issue Jan 22, 2021 · 8 comments
Closed

why are csv_dd and flmd templates in xlsx format? #3

regnans opened this issue Jan 22, 2021 · 8 comments
Assignees

Comments

@regnans
Copy link

regnans commented Jan 22, 2021

Submitter:

I suggest the following changes: it seems that csv would be fine here, and would prevent users from uploading xlsx

@wavingtowaves
Copy link

Good point, @tvelliquette, are you OK with me switching the .xlsx data dictionary files over to CSVs?

@tvelliquette
Copy link
Collaborator

@robcrystalornelas @regnans Switching to CSV is fine. This will be the case for any other .xlsx files that users will need to complete. I don't know if this will result in any changes to the documentation/instructions.

@wavingtowaves
Copy link

wavingtowaves commented Jan 27, 2021

@tvelliquette I've got the data dictionary uploaded as a CSV. Are you OK with me deleting the excel file from the repository? If we're OK with removing that excel file, my next to-do will be:

  • go through documentation and make sure nothing is linking to the deleted excel file.

@wavingtowaves
Copy link

@tvelliquette I went through and made sure all links to the template within the repo now point to the CSV version of the data dictionary instead of Excel. Going to close this issue.

tvelliquette added a commit that referenced this issue Jul 13, 2021
Updated #1 with text about creating one dd or multiple dd.

@robcrystalornelas Given this new option, is there any need for the wildcard option in #6? 

I also changed the word "column" to "field" in #3 since we are calling the column/row headers "fields" back in the CSV format structure.
@regnans
Copy link
Author

regnans commented Oct 19, 2021

Reopening this issue as the template files are now xlsx again.

@wavingtowaves
Copy link

Thanks for bringing this up @regnans!

In the rounds of revisions for the FLMD reporting format this fall, we decided that because xlsx are generally easier to download via the GitHub interface compared to CSV we would stick with Excel files in this repository. But I think there are some ways we can re-incorporate CSV files (see notes below). Just so we are all on the same page, I added in a few screenshots of the interfaces.

Excel file with download button:
image

CSV file without download button:
image

We did try to stress in FLMD instructions that anyone using a template should convert from Excel to CSV. But I think we have a couple other options we can consider:

  1. Also upload CSV files so that users can choose which they download
  2. Provide some instructions on how to download the CSV file from the GitHub interface by either clicking the green "code" button on the repository and downloading a whole zip of the repository OR navigating to the CSV file you want to download, right click "raw", then save your file being sure to add a ".csv" as the file extension.

@wavingtowaves wavingtowaves reopened this Oct 20, 2021
@regnans
Copy link
Author

regnans commented Oct 20, 2021

ah, I forgot about the download issue. That's not one of GitHub's best features! Thanks for your response, that makes sense to have excel for download. I'll close this again.

@regnans regnans closed this as completed Oct 20, 2021
@wavingtowaves
Copy link

👍 Sounds good, Kim!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants