-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
allow one to specify namespace or object selectors #43
allow one to specify namespace or object selectors #43
Conversation
f7de701
to
1127048
Compare
@KhrisRichardson-BO Thanks for the PR. Imo the point of setting the policy to |
@estahn I want the pod creation to fail if the mutation fails for whatever reason. I've observed a few instances where the image pull and push succeeded, but the pod spec mutation does not, resulting in the pod running with the public vs. private image repository, which is especially troublesome for nodes that cannot egress to the public image repository (i.e. - k8s-image-swapper runs on a tainted node that has permissions to egress). |
@KhrisRichardson-BO I see. I think it makes sense to have the ability to preselect what should be mutated by the webhook. Let's get it merged :) |
b883ae6
to
cb6fd75
Compare
charts/k8s-image-swapper/templates/mutatingWebhookConfiguration.yaml
Outdated
Show resolved
Hide resolved
charts/k8s-image-swapper/templates/mutatingWebhookConfiguration.yaml
Outdated
Show resolved
Hide resolved
cb6fd75
to
31d5d9e
Compare
@KhrisRichardson-BO Please ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed that.
charts/k8s-image-swapper/templates/mutatingWebhookConfiguration.yaml
Outdated
Show resolved
Hide resolved
charts/k8s-image-swapper/templates/mutatingWebhookConfiguration.yaml
Outdated
Show resolved
Hide resolved
31d5d9e
to
48dde24
Compare
Thanks, Enrico |
Without this, if one were to set the webhook policy to
Fail
, ak8s-image-swapper
pod would not be allowed to be created by kube-apiserver.