Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: config.target.aws.accountId changed from integer to string #47

Merged

Conversation

KhrisRichardson-BO
Copy link
Contributor

@KhrisRichardson-BO KhrisRichardson-BO commented Oct 25, 2021

When running k8s-image-swapper in an AWS account whose ID started with 0, we noticed the 0 getting silently dropped. I suspect changing the values.schema.json entry so that it matches the type in the Go struct will fix this particular issue, since our attempt to cast the value as a string encountered the following error:

Error: values don't meet the specifications of the schema(s) in the following chart(s):
k8s-image-swapper:
- config.target.aws.accountId: Invalid type. Expected: integer, given: string

Tasks

  • Bump the chart version (Chart.yaml -> version)
  • JSON Schema updated (values.schema.json)
  • Update README.md via helm-docs
  • Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

@KhrisRichardson-BO KhrisRichardson-BO force-pushed the k8s-image-swapper-schema-update branch from 19420dd to 970b4c3 Compare October 25, 2021 21:10
@estahn
Copy link
Owner

estahn commented Oct 26, 2021

Thanks for the contribution.

Makes sense. Just wondering if this is a breaking change 🤔

@KhrisRichardson-BO
Copy link
Contributor Author

Hi @estahn. I do suspect this change will prompt end-users to convert their integer values to string. Would you like me to increment the minor number instead? May I leave the wordsmithing to inform users of the change in your hands?

@estahn estahn changed the title fix: align schema with underlying Go struct fix: config.target.aws.accountId changed from integer to string Oct 26, 2021
@estahn estahn merged commit c432a89 into estahn:main Oct 26, 2021
@KhrisRichardson-BO KhrisRichardson-BO deleted the k8s-image-swapper-schema-update branch October 26, 2021 17:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants