Sentinel pool slave #103
Sentinel pool slave #103
Conversation
|
👍 |
|
today ? |
| def redisConnection: ActorRef = masterClient.redisConnection | ||
|
|
||
| override def send[T](redisCommand: RedisCommand[_ <: RedisReply, T]): Future[T] = { | ||
| if (redisCommand.isMasterOnly || slavesClients.getConnectionsActive.isEmpty) { |
There was a problem hiding this comment.
getConnectionsActive is expensive (even more for just a isEmpty)
I think we can cache the result of getConnectionsActive or something like that
I also think most of the time we only need 1 active connection
There was a problem hiding this comment.
I will replace by this
if (redisCommand.isMasterOnly || slavesClients.redisServers.exists(_.active.single.get)) {
masterClient.send(redisCommand)
} else {
slavesClients.send(redisCommand)
}
There was a problem hiding this comment.
yeah i think we can be even smarter trying to mix in the getNextConnection in RoundRobinPoolRequest
The ideal would be to find the next active connection in the RoundRobinPoolRequest
If we find it, then we have a slave where we can send the command. Otherwise we can send the command to the master.
There was a problem hiding this comment.
it exactly what happens: slavesClients is a RoundRobinPoolRequest
|
Can you put the return for all the function even |
| lazy val redisMasterSlavesPool = | ||
| SentinelMonitoredRedisClientMasterSlaves( master = masterName, | ||
| sentinels = sentinelPorts.map((redisHost, _))) | ||
| "sentienl slave pool" should { |
|
Hey, you are on the good path 😃 |
npeters
force-pushed
the
sentinel-pool-slave
branch
from
87455b9 to
c7de528
Compare
npeters
force-pushed
the
sentinel-pool-slave
branch
from
c7de528 to
762ecad
Compare
| @@ -35,13 +30,12 @@ abstract class RedisClientPoolLike(system: ActorRefFactory) extends RoundRobinPo | |||
| } | |||
| } | |||
|
|
|||
| val redisConnectionRef: Ref[Seq[ActorRef]] = Ref(getConnectionsActive) | |||
| lazy val redisConnectionRef: Ref[Seq[ActorRef]] = Ref(getConnectionsActive) | |||
There was a problem hiding this comment.
val redisConnectionRef: Ref[Seq[ActorRef]] = Ref(Seq.empty)
When we start we have no slave
There was a problem hiding this comment.
Okay I was wrong,
but can you remove the lazy
|
In the tests there are a lot of |
|
I finally find a bug on mutable pool |
|
thanks |
sentinel manage a slave pool: