Sentinel support #5
Conversation
- Add Sentinel protocol support - Some Tests
Conflicts: src/main/scala/redis/Redis.scala
| @@ -12,3 +12,5 @@ resolvers += "scct-github-repository" at "http://mtkopone.github.com/scct/maven- | |||
| addSbtPlugin("reaktor" % "sbt-scct" % "0.2-SNAPSHOT") | |||
|
|
|||
| addSbtPlugin("com.github.theon" %% "xsbt-coveralls-plugin" % "0.0.3") | |||
|
|
|||
| addSbtPlugin("com.github.mpeltonen" % "sbt-idea" % "1.5.1") | |||
There was a problem hiding this comment.
You can just add this to your ~/.sbt/plugins.sbt and get it for free across all projects without actually checking it in.
There was a problem hiding this comment.
Since I work with multiple machines, sometimes I totally forget to update ~/.sbt/plugins.sbt. So I thought it might be handy to have locally in the project.
- Some test modifications
|
@etaty, I thought about that, aka Decorator pattern. It should be definitely better than calling |
…actions as RedisClient does
|
|
||
| override def map(fs: => Fragments) = fs ^ Step(system.shutdown()) | ||
|
|
||
| def withRedisServer[T](block: Int => T): T = { |
There was a problem hiding this comment.
Maybe we could keep withRedisServer around ?
travis-ci.org is slow enough, i don't like to start a cluster if we don't need it.
There was a problem hiding this comment.
Good point. I'll try to fix it.
|
@etaty @ryanlecompte , please review. |
Do not create a new RedisClient instance each time Sentinel get notified on master server change, otherwise we'll lose all events in the old client queue.
|
@etaty , I made some more improvements since the last review. I'd be glad if you could have a look. Thanks. /cc @ryanlecompte |
|
Sorry for the delay @tovbinm. The updates look good to me! |
|
@tovbinm sorry i will look into it Saturday. (I am not sure about the way you changed the test, i think we can do a setup/cleanup with specs2. Not sure) |
|
Thanks @ryanlecompte, @etaty. |
|
Merged :) I will edit a little the tests. |
|
Awesome! |
|
We should probably update README as well. |
|
Yep, i wait for the release date (end of this week :) ). If you want to do it, you are welcome. |
Add support for Sentinel and use it for automatic master failover for master-slave(s) mode
Done:
TBD: