Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename cobra commands #732

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Rename cobra commands #732

merged 1 commit into from
Apr 18, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Apr 18, 2024

Remove the CobraCommand suffix, renaming them to just Command.

Fixes #731.

@ahrtr
Copy link
Member

ahrtr commented Apr 18, 2024

Please signoff the commit.

@ivanvc ivanvc force-pushed the rename-cobra-commands branch from 839af57 to ba568d4 Compare April 18, 2024 09:13
@ivanvc
Copy link
Member Author

ivanvc commented Apr 18, 2024

Please signoff the commit.

Oops, sorry, I committed it from a different workstation. Done.

@ahrtr
Copy link
Member

ahrtr commented Apr 18, 2024

could you squash the commits?

* Rename newInspectCobraCommand to newInspectCommand
* Rename newVersionCobraCommand to newVersionCommand

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the rename-cobra-commands branch from ba568d4 to 6ff4ce7 Compare April 18, 2024 09:36
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@ahrtr ahrtr merged commit f5447f0 into etcd-io:main Apr 18, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

Rename cobra commands
2 participants