move array related freelist functions into own file #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jun 26, 2024
freelist.go
Outdated
| // write writes the page ids onto a freelist page. All free and pending ids are | ||
| // saved to disk since in the event of a program crash, all pending ids will | ||
| // become free. | ||
| func (f *freelist) write(p *common.Page) error { |
There was a problem hiding this comment.
Please keep the write method in freelist.go because it has nothing to do with array or hashmap freelistType.
There was a problem hiding this comment.
copied too eagerly, moved it back where it was
tjungblu
force-pushed
the
freelist_first_array
branch
2 times, most recently
from
92ea985 to
39a1105
Compare
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
tjungblu
force-pushed
the
freelist_first_array
branch
from
39a1105 to
a4a52a2
Compare
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.