etcdserver: add "etcd_server_health_success/failures" #10156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #10156 +/- ##
==========================================
+ Coverage 71.54% 71.65% +0.11%
==========================================
Files 390 390
Lines 36307 36312 +5
==========================================
+ Hits 25975 26021 +46
+ Misses 8530 8484 -46
- Partials 1802 1807 +5
Continue to review full report at Codecov.
|
|
/cc @wenjiaswe |
xiang90
reviewed
Oct 8, 2018
| @@ -43,11 +44,6 @@ func HandlePrometheus(mux *http.ServeMux) { | |||
| mux.Handle(pathMetrics, promhttp.Handler()) | |||
| } | |||
|
|
|||
| // HandleHealth registers health handler on '/health'. | |||
There was a problem hiding this comment.
@xiang90 Yes, it was never used :)
|
lgtm |
1 similar comment
|
lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #10155, I am trying to improve server side metrics.
People use
/healthendpoint heavily to monitor etcd server status.Helpful to have server-side metrics to tell how many health check have been made, and how many of which were marked "failed".