Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

grpcproxy: fix memory leak #10327

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

namreg
Copy link

@namreg namreg commented Dec 15, 2018

use set instead of slice as interval value

fixes #10326

use set instead of slice as interval value

fixes etcd-io#10326
@namreg namreg force-pushed the fix-grpcproxy-memory-leak branch from e568abb to d88f686 Compare December 15, 2018 14:01
@namreg
Copy link
Author

namreg commented Dec 15, 2018

/assign @xiang90

@codecov-io
Copy link

Codecov Report

Merging #10327 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #10327     +/-   ##
=========================================
- Coverage   71.75%   71.66%   -0.1%     
=========================================
  Files         391      391             
  Lines       36414    36417      +3     
=========================================
- Hits        26130    26097     -33     
- Misses       8468     8499     +31     
- Partials     1816     1821      +5
Impacted Files Coverage Δ
proxy/grpcproxy/cache/store.go 95.71% <100%> (+0.19%) ⬆️
auth/options.go 47.5% <0%> (-45%) ⬇️
etcdserver/api/v3rpc/lease.go 67.04% <0%> (-10.23%) ⬇️
etcdserver/util.go 95% <0%> (-3.75%) ⬇️
lease/leasehttp/http.go 62.5% <0%> (-2.95%) ⬇️
etcdserver/api/v3compactor/revision.go 70.58% <0%> (-2.95%) ⬇️
raft/progress.go 94.17% <0%> (-1.95%) ⬇️
mvcc/watchable_store.go 83.5% <0%> (-1.76%) ⬇️
raft/node.go 91.22% <0%> (-1.53%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57f4f4...d88f686. Read the comment docs.

@namreg
Copy link
Author

namreg commented Dec 16, 2018

/assign @gyuho

@xiang90
Copy link
Contributor

xiang90 commented Dec 17, 2018

lgtm

@xiang90 xiang90 merged commit abb5736 into etcd-io:master Dec 17, 2018
@namreg namreg deleted the fix-grpcproxy-memory-leak branch December 17, 2018 06:43
@jingyih
Copy link
Contributor

jingyih commented Jan 28, 2019

cc @jpbetz @wenjiaswe

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

grpcproxy memory leak
4 participants