12125: panic: zap.Logger is nil in Embed client #12131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
approved these changes
Jul 13, 2020
spzala
reviewed
Jul 14, 2020
There was a problem hiding this comment.
I think we should cherry-pick the fix to 3.4 and 3.3 /cc @gyuho
@dissoupov would you like to work on cherry-pick?, thanks!
|
@spzala yes, the cherry-pick PR is being tested on 3.4, it's not applicable to 3.3 as Zap logger was not used yet. |
|
@dissoupov thanks, just reviewed the other PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #12125
NewCtxClientis used with Embedded server. This constructor does not create Logger, which is used by other packages, which causes a panic infunc New(s *etcdserver.EtcdServer) *clientv3.ClientThe fix introduces a default no-op logger and allows to copy the logger from the Embed Server, if specified.