clientv3/integration: add waitPinReady #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Oct 26, 2017
| @@ -70,6 +70,14 @@ func testBalancerUnderNetworkPartition(t *testing.T, op func(*clientv3.Client, c | |||
| } | |||
| defer cli.Close() | |||
|
|
|||
| // wait for ep[0] to be pinned | |||
| ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) | |||
There was a problem hiding this comment.
we used this in a lot of places. can you abstract this to a func like waitPinReady or something?
gyuho
changed the title
xiang90
reviewed
Oct 26, 2017
| @@ -96,3 +99,13 @@ func testBalancerUnderNetworkPartition(t *testing.T, op func(*clientv3.Client, c | |||
| t.Errorf("balancer did not switch in time (%v)", err) | |||
| } | |||
| } | |||
|
|
|||
| // waitPinReady waits until connection is up (new pinned address). | |||
| func waitPinReady(t *testing.T, cli *clientv3.Client) { | |||
|
lgtm |
RPC should be sent to trigger 'readyWait' on new pin address. Otherwise, endpoints other than ep[0] may be pinned. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8774 +/- ##
=========================================
Coverage ? 76.08%
=========================================
Files ? 360
Lines ? 29629
Branches ? 0
=========================================
Hits ? 22544
Misses ? 5515
Partials ? 1570
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC should be sent to trigger 'readyWait' on new pin address.
Otherwise, endpoints other than ep[0] may be pinned.