Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

*: move logging to embed, disable grpc server log by default #8810

Merged
merged 3 commits into from
Nov 2, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 2, 2017

Remove grpc logs when --debug=false:

WARNING: 2017/11/02 11:35:51 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp: operation was canceled"; Reconnecting to {localhost:2379 <nil>}
WARNING: 2017/11/02 11:35:51 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp: operation was canceled"; Reconnecting to {localhost:2379 <nil>}
INFO: 2017/11/02 11:35:51 get error from resetTransport grpc: the connection is closing, transportMonitor returning

@gyuho gyuho requested a review from xiang90 November 2, 2017 19:53
gyuho added 3 commits November 2, 2017 13:19
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@xiang90
Copy link
Contributor

xiang90 commented Nov 2, 2017

lgtm

1 similar comment
@fanminshi
Copy link
Member

lgtm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants