Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wal: allow non-WAL files in wal directory #9743

Merged
merged 3 commits into from
May 18, 2018
Merged

wal: allow non-WAL files in wal directory #9743

merged 3 commits into from
May 18, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 18, 2018

Fix #7287.

In other words, WAL directory with a single lost+found file will be considered not initialized.

gyuho added 3 commits May 18, 2018 10:28
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
WAL never writes nor needs files without ".wal" suffix.
Thus, safe to filter out only ".wal" files.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #9743 into master will decrease coverage by 0.21%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9743      +/-   ##
==========================================
- Coverage   69.56%   69.34%   -0.22%     
==========================================
  Files         374      375       +1     
  Lines       35115    35128      +13     
==========================================
- Hits        24427    24359      -68     
- Misses       8928     9010      +82     
+ Partials     1760     1759       -1
Impacted Files Coverage Δ
pkg/fileutil/fileutil.go 61.11% <ø> (-4.11%) ⬇️
wal/util.go 80% <100%> (ø) ⬆️
pkg/fileutil/read_dir.go 91.3% <91.3%> (ø)
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
pkg/adt/interval_tree.go 79.87% <0%> (-8.71%) ⬇️
etcdserver/apply.go 82.36% <0%> (-6.66%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-5.74%) ⬇️
raft/progress.go 94.17% <0%> (-1.95%) ⬇️
discovery/discovery.go 67.2% <0%> (-1.62%) ⬇️
raft/node.go 90.83% <0%> (-1.6%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4e8e9...12a2275. Read the comment docs.

@gyuho gyuho merged commit 41133eb into etcd-io:master May 18, 2018
@gyuho gyuho deleted the wal branch May 18, 2018 19:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants