auth: Support all JWT algorithms #9883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9883 +/- ##
==========================================
+ Coverage 68.96% 69.25% +0.29%
==========================================
Files 385 386 +1
Lines 35703 35731 +28
==========================================
+ Hits 24621 24744 +123
+ Misses 9263 9190 -73
+ Partials 1819 1797 -22
Continue to review full report at Codecov.
|
gyuho
reviewed
Jun 26, 2018
| ErrInvalidAuthMethod = errors.New("auth: invalid auth signature method") | ||
| ErrMissingKey = errors.New("auth: missing key data") | ||
| ErrKeyMismatch = errors.New("auth: public and private keys don't match") | ||
| ErrVerifyOnly = errors.New("auth: token signing attempted with verify-only key") |
There was a problem hiding this comment.
I don't see ErrVerifyOnly being used anywhere?
There was a problem hiding this comment.
Good catch, thanks.
There was a problem hiding this comment.
Updated, and added a test case to ensure it's returned.
This change adds support to etcd for all of the JWT algorithms included in the underlying JWT library.
gyuho
approved these changes
Jun 26, 2018
|
lgtm, thanks! @joelegasse |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to etcd for all of the JWT algorithms included in the underlying JWT library.
Fixes #9696