Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for RequestProgress for Watch? #928

Closed
mikehuston opened this issue Jun 10, 2021 · 11 comments
Closed

Support for RequestProgress for Watch? #928

mikehuston opened this issue Jun 10, 2021 · 11 comments

Comments

@mikehuston
Copy link

I'd like to use the RequestProgress functionality added etcd-io/etcd#9869 in this Java etcd client.

Use case is similar to the one mentioned in that PR; I'd like to maintain an in-memory cache of an etcd key range and use RequestProgress in combination with a quorum read so that I can know when my cached data may be out of date.

I looked at the Watch interface and impl and it did not appear RequestProgress support had been added yet. Are there plans to add this functionality and/or would you welcome a pull request if I can find time?
@lburgazzoli
Copy link
Collaborator

A PR would be very welcome !

@mikehuston
Copy link
Author

Excellent, thanks @lburgazzoli! I'll take a shot at a PR, using the Go client change as a reference.

juliankung-db added a commit to juliankung-db/jetcd that referenced this issue Jul 29, 2021
@juliankung-db
Add requestProgress function to Watch
d824f90 
Added a function that requests a watch stream progress status
be sent in the watch response stream as soon as possible. This is
helpful in situations where an application may want to check the
progress of a watch to determine how up-to-date the watch stream is.

Addresses etcd-io#928
@juliankung-db juliankung-db mentioned this issue Jul 29, 2021
Merged
juliankung-db added a commit to juliankung-db/jetcd that referenced this issue Jul 29, 2021
@juliankung-db
Add requestProgress function to Watch
d62d2e4 
Added a function that requests a watch stream progress status
be sent in the watch response stream as soon as possible. This is
helpful in situations where an application may want to check the
progress of a watch to determine how up-to-date the watch stream is.

Addresses etcd-io#928
juliankung-db added a commit to juliankung-db/jetcd that referenced this issue Jul 29, 2021
@juliankung-db
Add requestProgress function to Watch
eef02e7 
Added a function that requests a watch stream progress status
be sent in the watch response stream as soon as possible. This is
helpful in situations where an application may want to check the
progress of a watch to determine how up-to-date the watch stream is.

Addresses etcd-io#928
@juliankung-db
Copy link
Contributor

PR opened for this change #957

@mikehuston
Copy link
Author

Thanks @juliankung-db! (we work at same company). After this merges, @lburgazzoli do you know how soon a new release including it might be available? We're trying to weigh different options for being able to use this functionality in our company's codebase. Many thanks!

@lburgazzoli
Copy link
Collaborator

I can release as often as it is needed so I'll have a look at the pr tomorrow then we can discuss about a release

juliankung-db added a commit to juliankung-db/jetcd that referenced this issue Jul 29, 2021
@juliankung-db
Add requestProgress function to Watch
157cf38 
Added a function that requests a watch stream progress status
be sent in the watch response stream as soon as possible. This is
helpful in situations where an application may want to check the
progress of a watch to determine how up-to-date the watch stream is.

Addresses etcd-io#928
lburgazzoli pushed a commit that referenced this issue Jul 30, 2021
@juliankung-db @lburgazzoli
Add requestProgress function to Watch
b83f6bf 
Added a function that requests a watch stream progress status
be sent in the watch response stream as soon as possible. This is
helpful in situations where an application may want to check the
progress of a watch to determine how up-to-date the watch stream is.

Addresses #928
@juliankung-db
Copy link
Contributor

Thanks for the quick turnaround on the review and merge @lburgazzoli :^)

In terms of the release, it'd be great on our side if it'd be possible to create a new release in the next week or two (please let us know if we can help). If not, we can look at short-term workarounds until the next release.

@lburgazzoli
Copy link
Collaborator

In terms of the release, it'd be great on our side if it'd be possible to create a new release in the next week or two (please let us know if we can help). If not, we can look at short-term workarounds until the next release.

I can plan to do a release over the week-end or beginning next week.
Ping me if you don't hear back from me about the release.

@juliankung-db
Copy link
Contributor

Hey I just wanted to quickly ping for an update on the release. Will the release be happening around the beginning of next week (8/9)?

@lburgazzoli
Copy link
Collaborator

Sorry for the delay, I have released it now.
Should be available on maven central in a few hours

@lburgazzoli
Copy link
Collaborator

@juliankung-db can we close this issue now ?

@juliankung-db
Copy link
Contributor

Yep, looks like everything's good and working on our end, thanks :^)

Feel free to close it, @mikehuston is OOO until next week so he won't be able to close it until then

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lburgazzoli @mikehuston @juliankung-db