Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

method 'get_common_ancestor' when nodes being compared are equal #398

Closed
arivers opened this issue Mar 27, 2019 · 0 comments · Fixed by #452
Closed

method 'get_common_ancestor' when nodes being compared are equal #398

arivers opened this issue Mar 27, 2019 · 0 comments · Fixed by #452
Assignees
@dengzq1234
Labels
bug-minor
Milestone
ETE v4.0

Comments

@arivers
Copy link

arivers commented Mar 27, 2019

if get_common_ancestor is called with two identical trees the method returns the highest common ancestor rather than the lowest common ancestor.

ncbitree.get_common_ancestor([str(9606), str(9606)])
PhyloTree node '1' (-0x7ffffd502bce2abd)

As a workaround I put a check in before calling the method, but the result was unexpected.
@jhcepas jhcepas added this to the ETE v4.0 milestone Mar 28, 2020
dengzq1234 added a commit to dengzq1234/ete that referenced this issue Mar 29, 2020
@dengzq1234
return mrca when target nodes are equal etetoolkit#398
e755a3e
@jhcepas jhcepas mentioned this issue Mar 30, 2020
Merged
jhcepas added a commit that referenced this issue Mar 30, 2020
@jhcepas
Merge pull request #452 from etetoolkit/mca_method_issue_398
6cad2f7 
returns itself if same node is provided as only argument to get_common_ancestor. Fixes #398
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dengzq1234 dengzq1234

Labels
bug-minor
Projects
None yet
Milestone
ETE v4.0
Development

Successfully merging a pull request may close this issue.

returns itself if same node is provided as only argument of get_common_ancestor etetoolkit/ete
3 participants
@jhcepas @arivers @dengzq1234