Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

more BSCSCAN_TOKEN #1062

Merged
merged 1 commit into from
Apr 17, 2021
Merged

more BSCSCAN_TOKEN #1062

merged 1 commit into from
Apr 17, 2021

Conversation

BlinkyStitt
Copy link
Collaborator

What I did

I found a spot where we were still using ETHERSCAN_TOKEN instead of BSCSCAN_TOKEN.

How to verify it

$ export BSCSCAN_TOKEN=xxx
$ brownie --network bsc-main console
>>> Contract.from_explorer("0x2170ed0880ac9a755fd29b2688956bd959f933f8")

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

iamdefinitelyahuman
iamdefinitelyahuman approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff history, I don't think this is a regression - it was just never added. Guessing bscscan recently modified something in their API due to an increase in requests?

@iamdefinitelyahuman iamdefinitelyahuman merged commit d392799 into eth-brownie:master Apr 17, 2021
@poolpitako
Copy link
Contributor

yep, that's my bad. I am using ETHERSCAN_TOKEN for the bsc token.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlinkyStitt @poolpitako @iamdefinitelyahuman