bash completion #58
Draft
bash completion #58
+243
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjanalik
force-pushed
the
feature/bash-completion
branch
from
bc3db30 to
db9077f
Compare
rjanalik
force-pushed
the
feature/bash-completion
branch
from
db9077f to
d3cd2c2
Compare
rjanalik
force-pushed
the
feature/bash-completion
branch
from
b2e1059 to
2e49f41
Compare
rjanalik
force-pushed
the
feature/bash-completion
branch
from
2e49f41 to
f725244
Compare
rjanalik
force-pushed
the
feature/bash-completion
branch
from
c42d470 to
6d815ef
Compare
bcumming
requested changes
Feb 27, 2025
rjanalik
commented
Mar 1, 2025
| }; | ||
|
|
||
| struct global_settings { | ||
| using enum cli_mode; | ||
|
|
||
| int verbose = 0; | ||
| cli_mode mode = unset; | ||
| CLI::App* cli; |
There was a problem hiding this comment.
@bcumming I added this because I need a starting point to generate the completion script. Do you know how to get the pointer to CLI::App without adding it to the global_settings?
There was a problem hiding this comment.
I left a comment in src/cli/completion.h with a suggestion for where to keep this information.
bcumming
reviewed
Mar 2, 2025
| void completion_help(); | ||
|
|
||
| struct completion_args { | ||
| std::string shell_description; |
There was a problem hiding this comment.
Store the CLI::App* in this type, and add a constructor ftakes the CLI::App* as an argument, instead of storing it in the main settings.
bcumming
requested changes
Mar 2, 2025
| }; | ||
|
|
||
| struct global_settings { | ||
| using enum cli_mode; | ||
|
|
||
| int verbose = 0; | ||
| cli_mode mode = unset; | ||
| CLI::App* cli; |
There was a problem hiding this comment.
I left a comment in src/cli/completion.h with a suggestion for where to keep this information.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.