Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use CrossUnsafe for Interop Ingress Filter #428

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Use CrossUnsafe for Interop Ingress Filter #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/txpool/ingress_filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,7 @@ func (f *interopFilter) FilterTx(ctx context.Context, tx *types.Transaction) boo
ctx, cancel := context.WithTimeout(ctx, time.Second*2)
defer cancel()
// check with the supervisor if the transaction should be allowed given the executing messages
return f.checkFn(ctx, ems, interoptypes.Unsafe) == nil
// the message can be unsafe (discovered only via P2P unsafe blocks), but it must be cross-valid
// so CrossUnsafe is used here
return f.checkFn(ctx, ems, interoptypes.CrossUnsafe) == nil
}