Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align HoloceneTime printout in banner #477

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Jan 27, 2025

This is upsetting:

INFO [01-27|11:20:17.248]
INFO [01-27|11:20:17.248] Post-Merge hard forks (timestamp based):
INFO [01-27|11:20:17.248]  - Shanghai:                    @0          (https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/shanghai.md)
INFO [01-27|11:20:17.248]  - Cancun:                      @0          (https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md)
INFO [01-27|11:20:17.248]  - Regolith:                    @0
INFO [01-27|11:20:17.248]  - Canyon:                      @0
INFO [01-27|11:20:17.248]  - Ecotone:                     @0
INFO [01-27|11:20:17.248]  - Fjord:                       @0
INFO [01-27|11:20:17.248]  - Granite:                     @0
INFO [01-27|11:20:17.248]  - Holocene:                     @0
INFO [01-27|11:20:17.248]

Drive-by comment: is there a reason we don't link to specs for hardforks anymore?

@geoknee geoknee requested a review from a team as a code owner January 27, 2025 11:26
@geoknee geoknee requested a review from axelKingsley January 27, 2025 11:26
@geoknee geoknee merged commit c058cf2 into optimism Jan 28, 2025
7 checks passed
@geoknee geoknee deleted the gk/align-holocene-banner branch January 28, 2025 16:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants